[pypy-commit] jitviewer argparse-collect: Search the PATH when invoking pypy interpreter for log collection.

vext01 noreply at buildbot.pypy.org
Thu Sep 5 17:09:51 CEST 2013


Author: Edd Barrett <vext01 at gmail.com>
Branch: argparse-collect
Changeset: r236:a4f3ed9615b6
Date: 2013-08-30 23:35 +0100
http://bitbucket.org/pypy/jitviewer/changeset/a4f3ed9615b6/

Log:	Search the PATH when invoking pypy interpreter for log collection.

diff --git a/_jitviewer/app.py b/_jitviewer/app.py
--- a/_jitviewer/app.py
+++ b/_jitviewer/app.py
@@ -197,14 +197,14 @@
     """ Collect a log file using pypy """
 
     # XXX Randomise log file name
-    # XXX Search path
 
     import subprocess
 
-    p = subprocess.Popen(args,
-            env={"PYPYLOG" : "jit-log-opt,jit-backend:%s" % (logpath, )}
-    )
-    p.communicate()
+    # possibly make this configurable if someone asks...
+    os.environ["PYPYLOG"] = "jit-log-opt,jit-backend:%s" % (logpath, )
+    print("Collecting log...")
+    p = subprocess.Popen(args, env=os.environ).communicate()
+
     # We don't check the return status. The user may want to see traces
     # for a failing program!
     return os.path.abspath(logpath)


More information about the pypy-commit mailing list