[pypy-commit] pypy stmgc-c4: stm: remove redundant fallback to inevitable in stmrewrite

Raemi noreply at buildbot.pypy.org
Wed Sep 18 10:36:43 CEST 2013


Author: Remi Meier <remi.meier at gmail.com>
Branch: stmgc-c4
Changeset: r66996:a80fc85febae
Date: 2013-09-18 10:35 +0200
http://bitbucket.org/pypy/pypy/changeset/a80fc85febae/

Log:	stm: remove redundant fallback to inevitable in stmrewrite

diff --git a/rpython/jit/backend/llsupport/stmrewrite.py b/rpython/jit/backend/llsupport/stmrewrite.py
--- a/rpython/jit/backend/llsupport/stmrewrite.py
+++ b/rpython/jit/backend/llsupport/stmrewrite.py
@@ -105,10 +105,14 @@
             # ----------  calls  ----------
             if op.is_call():
                 if op.getopnum() == rop.CALL_RELEASE_GIL:
-                    self.fallback_inevitable(op)
+                    # self.fallback_inevitable(op)
+                    # done by assembler._release_gil_shadowstack()
+                    self.newops.append(op)
                 elif op.getopnum() == rop.CALL_ASSEMBLER:
                     self.handle_call_assembler(op)
                 else:
+                    # only insert become_inevitable if calling a
+                    # non-transactionsafe and non-releasegil function
                     descr = op.getdescr()
                     assert not descr or isinstance(descr, CallDescr)
                     if not descr or not descr.get_extra_info() \


More information about the pypy-commit mailing list