[pypy-commit] pypy default: show where test_simple_tcp fails

bdkearns noreply at buildbot.pypy.org
Tue Apr 22 00:05:02 CEST 2014


Author: Brian Kearns <bdkearns at gmail.com>
Branch: 
Changeset: r70841:52e1124ad331
Date: 2014-04-21 14:48 -0700
http://bitbucket.org/pypy/pypy/changeset/52e1124ad331/

Log:	show where test_simple_tcp fails

diff --git a/rpython/rlib/test/test_rsocket.py b/rpython/rlib/test/test_rsocket.py
--- a/rpython/rlib/test/test_rsocket.py
+++ b/rpython/rlib/test/test_rsocket.py
@@ -165,11 +165,11 @@
     sock.listen(1)
     s2 = RSocket(AF_INET, SOCK_STREAM)
     s2.settimeout(10.0) # test one side with timeouts so select is used, shouldn't affect test
+    connected = False
     def connecting():
         try:
             s2.connect(addr)
-        except:
-            s2.close()
+            connected = True
         finally:
             lock.release()
     lock = thread.allocate_lock()
@@ -180,6 +180,7 @@
     s1 = RSocket(fd=fd1)
     print 'connection accepted'
     lock.acquire()
+    assert connected
     print 'connecting side knows that the connection was accepted too'
     assert addr.eq(s2.getpeername())
     #assert addr2.eq(s2.getsockname())


More information about the pypy-commit mailing list