[pypy-commit] pypy py3.3: patching cpython3 csv test as the exception message has bad grammar

numerodix noreply at buildbot.pypy.org
Sat Jul 26 13:02:24 CEST 2014


Author: Martin Matusiak <numerodix at gmail.com>
Branch: py3.3
Changeset: r72493:c94a608f5616
Date: 2014-07-26 11:11 +0200
http://bitbucket.org/pypy/pypy/changeset/c94a608f5616/

Log:	patching cpython3 csv test as the exception message has bad grammar

diff --git a/lib-python/3/test/test_csv.py b/lib-python/3/test/test_csv.py
--- a/lib-python/3/test/test_csv.py
+++ b/lib-python/3/test/test_csv.py
@@ -766,8 +766,9 @@
         mydialect.quotechar = "''"
         with self.assertRaises(csv.Error) as cm:
             mydialect()
+        # NOTE: Patched exception message since cpython uses bad grammar (cpython issue22076)
         self.assertEqual(str(cm.exception),
-                         '"quotechar" must be an 1-character string')
+                         '"quotechar" must be a 1-character string')
 
         mydialect.quotechar = 4
         with self.assertRaises(csv.Error) as cm:
@@ -789,14 +790,16 @@
         mydialect.delimiter = ":::"
         with self.assertRaises(csv.Error) as cm:
             mydialect()
+        # NOTE: Patched exception message since cpython uses bad grammar (cpython issue22076)
         self.assertEqual(str(cm.exception),
-                         '"delimiter" must be an 1-character string')
+                         '"delimiter" must be a 1-character string')
 
         mydialect.delimiter = ""
         with self.assertRaises(csv.Error) as cm:
             mydialect()
+        # NOTE: Patched exception message since cpython uses bad grammar (cpython issue22076)
         self.assertEqual(str(cm.exception),
-                         '"delimiter" must be an 1-character string')
+                         '"delimiter" must be a 1-character string')
 
         mydialect.delimiter = b","
         with self.assertRaises(csv.Error) as cm:


More information about the pypy-commit mailing list