[pypy-commit] pypy gc-incminimark-pinning: remove XXX that was achieved

groggi noreply at buildbot.pypy.org
Mon Jun 2 17:24:50 CEST 2014


Author: Gregor Wegberg <code at gregorwegberg.com>
Branch: gc-incminimark-pinning
Changeset: r71860:08dc504395e4
Date: 2014-05-29 20:37 +0200
http://bitbucket.org/pypy/pypy/changeset/08dc504395e4/

Log:	remove XXX that was achieved

	well, there is a lot still to test. However, for now we have a test.

diff --git a/rpython/memory/gc/test/test_object_pinning.py b/rpython/memory/gc/test/test_object_pinning.py
--- a/rpython/memory/gc/test/test_object_pinning.py
+++ b/rpython/memory/gc/test/test_object_pinning.py
@@ -192,6 +192,7 @@
         assert self.gc.pinned_objects_in_nursery == 3
 
         self.gc.minor_collection()
+        # now the one not on the stack should be gone.
         assert self.gc.pinned_objects_in_nursery == 2
         assert ptr_stackroot_1.someInt == 100
         assert ptr_stackroot_2.someInt == 100
@@ -217,6 +218,4 @@
 
     # XXX test/define what happens if we try to pin an object that is too
     # big for the nursery and will be raw-malloc'ed.
-
-    # XXX fill nursery with pinned objects -> + define behavior for such a
-    # case
+    


More information about the pypy-commit mailing list