[pypy-commit] pypy default: Update comment
arigo
noreply at buildbot.pypy.org
Thu Jun 26 14:30:28 CEST 2014
Author: Armin Rigo <arigo at tunes.org>
Branch:
Changeset: r72245:8a9c64ba35dc
Date: 2014-06-26 14:29 +0200
http://bitbucket.org/pypy/pypy/changeset/8a9c64ba35dc/
Log: Update comment
diff --git a/rpython/translator/c/src/thread_gil.c b/rpython/translator/c/src/thread_gil.c
--- a/rpython/translator/c/src/thread_gil.c
+++ b/rpython/translator/c/src/thread_gil.c
@@ -54,10 +54,10 @@
{
/* Acquires the GIL.
- XXX Note: this function saves and restores 'errno'. This is
- needed for now because it may be *followed* by reading the
- 'errno', although it's kind of bogus: it should be read before
- calling RPyGilAcquire().
+ Note: in the slow path, this function saves and restores 'errno'.
+ This is needed for now because it may be *followed* by reading
+ the 'errno'. It's a bit strange, because we could read the errno
+ before calling RPyGilAcquire(), but it's simpler this way.
*/
long old_fastgil = lock_test_and_set(&rpy_fastgil, 1);
More information about the pypy-commit
mailing list