[pypy-commit] pypy default: Hah, suggesting "translation.shared" to be equal to "sys.platform ==

arigo noreply at buildbot.pypy.org
Wed Nov 5 20:17:22 CET 2014


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r74350:b8b322eb7b99
Date: 2014-11-05 20:16 +0100
http://bitbucket.org/pypy/pypy/changeset/b8b322eb7b99/

Log:	Hah, suggesting "translation.shared" to be equal to "sys.platform ==
	'win32'" is a bad idea because that is False on non-Windows. It
	hides completely the default value choosen for it in
	translationoption.py.

diff --git a/pypy/config/pypyoption.py b/pypy/config/pypyoption.py
--- a/pypy/config/pypyoption.py
+++ b/pypy/config/pypyoption.py
@@ -86,9 +86,10 @@
     # itself needs the interp-level struct module
     # because 'P' is missing from the app-level one
     "_rawffi": [("objspace.usemodules.struct", True)],
-    "cpyext": [("translation.secondaryentrypoints", "cpyext,main"),
-               ("translation.shared", sys.platform == "win32")],
+    "cpyext": [("translation.secondaryentrypoints", "cpyext,main")],
 }
+if sys.platform == "win32":
+    module_suggests["cpyext"].append(("translation.shared", True))
 
 module_import_dependencies = {
     # no _rawffi if importing rpython.rlib.clibffi raises ImportError


More information about the pypy-commit mailing list