[pypy-commit] pypy default: extract the costly call to check_no_flags() in a separate method

rlamy noreply at buildbot.pypy.org
Sun Nov 16 21:24:43 CET 2014


Author: Ronan Lamy <ronan.lamy at gmail.com>
Branch: 
Changeset: r74541:12ca083b8119
Date: 2014-11-16 20:24 +0000
http://bitbucket.org/pypy/pypy/changeset/12ca083b8119/

Log:	extract the costly call to check_no_flags() in a separate method

diff --git a/rpython/annotator/annrpython.py b/rpython/annotator/annrpython.py
--- a/rpython/annotator/annrpython.py
+++ b/rpython/annotator/annrpython.py
@@ -223,6 +223,7 @@
                 self.setbinding(v, annmodel.s_ImpossibleValue)
         # policy-dependent computation
         self.bookkeeper.compute_at_fixpoint()
+        self.bookkeeper.check_no_flags_on_instances()
 
     def annotation(self, arg):
         "Gives the SomeValue corresponding to the given Variable or Constant."
diff --git a/rpython/annotator/bookkeeper.py b/rpython/annotator/bookkeeper.py
--- a/rpython/annotator/bookkeeper.py
+++ b/rpython/annotator/bookkeeper.py
@@ -110,8 +110,8 @@
         finally:
             self.leave()
 
+    def check_no_flags_on_instances(self):
         # sanity check: no flags attached to heap stored instances
-
         seen = set()
 
         def check_no_flags(s_value_or_def):


More information about the pypy-commit mailing list