[pypy-commit] stmgc default: more questions

[Raemi]

Author: Remi Meier <remi.meier at inf.ethz.ch>
Branch: 
Changeset: r1345:72825d611f91
Date: 2014-09-04 10:51 +0200
http://bitbucket.org/pypy/stmgc/changeset/72825d611f91/

Log:	more questions

diff --git a/c8/stm/core.c b/c8/stm/core.c
--- a/c8/stm/core.c
+++ b/c8/stm/core.c
@@ -15,6 +15,8 @@
         /* send to GDB */
         kill(getpid(), SIGINT);
     }
+    /* XXX: should we save 'errno'? */
+
     /* make PROT_READWRITE again and validate */
     int segnum = get_segment_of_linear_address(addr);
     OPT_ASSERT(segnum == STM_SEGMENT->segment_num);
@@ -25,6 +27,8 @@
     /* XXX: missing synchronisation: we may change protection, then
        another thread changes it back, then we try to privatize that
        calls page_copy() and traps */
+    /* XXX: mprotect is not reentrant and interruptible by signals,
+       so it needs additional synchronisation.*/
     mprotect(seg_base + pagenum * 4096UL, 4096, PROT_READ|PROT_WRITE);
     page_privatize(pagenum);