[pypy-commit] pypy gc-incminimark-pinning: add XXX with possible solution for a nursery with too many pinned objects

groggi noreply at buildbot.pypy.org
Fri Sep 5 11:37:56 CEST 2014


Author: Gregor Wegberg <code at gregorwegberg.com>
Branch: gc-incminimark-pinning
Changeset: r73316:24a441449f40
Date: 2014-09-05 11:32 +0200
http://bitbucket.org/pypy/pypy/changeset/24a441449f40/

Log:	add XXX with possible solution for a nursery with too many pinned
	objects

diff --git a/rpython/memory/gc/incminimark.py b/rpython/memory/gc/incminimark.py
--- a/rpython/memory/gc/incminimark.py
+++ b/rpython/memory/gc/incminimark.py
@@ -775,6 +775,11 @@
                                 # enough space to allocate the object
                                 pass
                 else:
+                    # XXX (groggi) possible solutions:
+                    # - gc-incminimark-pinning-arealimit branch (pretty simple, downsides in regard what can be pinned)
+                    # - do raw_malloc (probably best idea, but also quit some code changes needed)
+                    # - make in some way sure that after a minor collection
+                    #   enough space can be reserved (probably a bad idea in regard to performance)
                     ll_assert(minor_collection_count == 2,
                         "Seeing minor_collection() at least twice. "
                         "Too many pinned objects?")


More information about the pypy-commit mailing list