[pypy-commit] pypy gc-incminimark-pinning: add comment (XXX) for possible improvement of rzlib by using pinning

[groggi]

Author: Gregor Wegberg <code at gregorwegberg.com>
Branch: gc-incminimark-pinning
Changeset: r73373:0d68a93239a5
Date: 2014-09-08 12:27 +0200
http://bitbucket.org/pypy/pypy/changeset/0d68a93239a5/

Log:	add comment (XXX) for possible improvement of rzlib by using pinning

diff --git a/rpython/rlib/rzlib.py b/rpython/rlib/rzlib.py
--- a/rpython/rlib/rzlib.py
+++ b/rpython/rlib/rzlib.py
@@ -346,6 +346,8 @@
     """
     # Prepare the input buffer for the stream
     with lltype.scoped_alloc(rffi.CCHARP.TO, len(data)) as inbuf:
+        # XXX (groggi) should be possible to improve this with pinning by
+        # not performing the 'copy_string_to_raw' if non-movable/pinned
         copy_string_to_raw(llstr(data), inbuf, 0, len(data))
         stream.c_next_in = rffi.cast(Bytefp, inbuf)
         rffi.setintfield(stream, 'c_avail_in', len(data))