[pypy-commit] pypy use-file-star-for-file: add comment

bdkearns noreply at buildbot.pypy.org
Sat Sep 20 23:19:51 CEST 2014


Author: Brian Kearns <bdkearns at gmail.com>
Branch: use-file-star-for-file
Changeset: r73618:509fd1d325f2
Date: 2014-09-20 17:19 -0400
http://bitbucket.org/pypy/pypy/changeset/509fd1d325f2/

Log:	add comment

diff --git a/rpython/rlib/rfile.py b/rpython/rlib/rfile.py
--- a/rpython/rlib/rfile.py
+++ b/rpython/rlib/rfile.py
@@ -443,6 +443,7 @@
                 s.append_charpsize(raw_buf, chunksize)
                 buffersize = self._new_buffersize(buffersize)
                 remainsize = buffersize - s.getlength()
+                # XXX add rpython realloc so we can avoid the copy to stringbuilder?
                 rffi.keep_buffer_alive_until_here(raw_buf, gc_buf)
                 raw_buf, gc_buf = rffi.alloc_buffer(remainsize)
             if s is None:
@@ -505,6 +506,7 @@
                 s.append_charpsize(raw_buf, remainsize - 1)
                 buffersize += buffersize >> 2
                 remainsize = buffersize - s.getlength()
+                # XXX add rpython realloc so we can avoid the copy to stringbuilder?
                 rffi.keep_buffer_alive_until_here(raw_buf, gc_buf)
                 raw_buf, gc_buf = rffi.alloc_buffer(remainsize)
             if s is None:
@@ -609,6 +611,7 @@
                 s.append_charpsize(raw_buf, i)
                 buffersize += buffersize >> 2
                 remainsize = buffersize - s.getlength()
+                # XXX add rpython realloc so we can avoid the copy to stringbuilder?
                 rffi.keep_buffer_alive_until_here(raw_buf, gc_buf)
                 raw_buf, gc_buf = rffi.alloc_buffer(remainsize)
                 i = 0


More information about the pypy-commit mailing list