[pypy-commit] pypy reverse-debugger: 'forward' is potentially dangerous if used after RPython commands mucked

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: reverse-debugger
Changeset: r85109:9524af3f0d05
Date: 2016-06-12 19:12 +0200
http://bitbucket.org/pypy/pypy/changeset/9524af3f0d05/

Log:	'forward' is potentially dangerous if used after RPython commands
	mucked with objects. rename '__forward'

diff --git a/rpython/translator/revdb/rdb-src/revdb.c b/rpython/translator/revdb/rdb-src/revdb.c
--- a/rpython/translator/revdb/rdb-src/revdb.c
+++ b/rpython/translator/revdb/rdb-src/revdb.c
@@ -776,9 +776,9 @@
 {
     static struct action_s actions_1[] = {
         { "go", act_go },
-        { "forward", act_forward },
         { "info", act_info },
         { "quit", act_quit },
+        { "__forward", act_forward },
         { "", act_nop },
         { NULL }
     };
diff --git a/rpython/translator/revdb/test/test_basic.py b/rpython/translator/revdb/test/test_basic.py
--- a/rpython/translator/revdb/test/test_basic.py
+++ b/rpython/translator/revdb/test/test_basic.py
@@ -234,13 +234,13 @@
         child = self.replay()
         child.sendline('go 1')
         child.expectx('(1)$ ')
-        child.sendline('forward 1')
+        child.sendline('__forward 1')
         child.expectx('(2)$ ')
-        child.sendline('forward 1')
+        child.sendline('__forward 1')
         child.expectx('(3)$ ')
         child.sendline('info fork')
         child.expectx('most_recent_fork=1\r\n')
-        child.sendline('forward 1')
+        child.sendline('__forward 1')
         child.expectx('At end.\r\n'
                       '(3)$ ')
         child.sendline('info fork')
@@ -324,7 +324,7 @@
         child.expectx('<<<oops>>>\r\n')
         child.expectx('Attempted to do I/O or access raw memory\r\n'
                       '(1)$ ')
-        child.sendline('forward 50')
+        child.sendline('__forward 50')
         child.expectx('At end.\r\n'
                       '(3)$ ')