[pypy-commit] pypy cpyext-cleanup: Remove always-empty 'functions' from generate_decls_and_callback()

[rlamy]

Author: Ronan Lamy <ronan.lamy at gmail.com>
Branch: cpyext-cleanup
Changeset: r89369:083af902cb24
Date: 2017-01-05 00:16 +0000
http://bitbucket.org/pypy/pypy/changeset/083af902cb24/

Log:	Remove always-empty 'functions' from generate_decls_and_callback()

diff --git a/pypy/module/cpyext/api.py b/pypy/module/cpyext/api.py
--- a/pypy/module/cpyext/api.py
+++ b/pypy/module/cpyext/api.py
@@ -1014,9 +1014,10 @@
     db = LowLevelDatabase()
     prefix = 'cpyexttest'
 
-    functions = generate_decls_and_callbacks(db, prefix=prefix)
+    generate_decls_and_callbacks(db, prefix=prefix)
 
     # Structure declaration code
+    functions = []
     members = []
     structindex = {}
     for header, header_functions in FUNCTIONS_BY_HEADER.iteritems():
@@ -1222,8 +1223,7 @@
     pypy_macros_h = udir.join('pypy_macros.h')
     pypy_macros_h.write('\n'.join(pypy_macros))
 
-    # implement function callbacks and generate function decls
-    functions = []
+    # generate function decls
     decls = {}
     pypy_decls = decls[pypy_decl] = []
     pypy_decls.append('#define Signed   long           /* xxx temporary fix */\n')
@@ -1267,7 +1267,6 @@
     for header_name, header_decls in decls.iteritems():
         decl_h = udir.join(header_name)
         decl_h.write('\n'.join(header_decls))
-    return functions
 
 separate_module_files = [source_dir / "varargwrapper.c",
                          source_dir / "pyerrors.c",
@@ -1374,12 +1373,11 @@
     db = LowLevelDatabase()
     prefix = 'PyPy'
 
-    functions = generate_decls_and_callbacks(db, prefix=prefix)
+    generate_decls_and_callbacks(db, prefix=prefix)
 
     code = "#include <Python.h>\n"
     if use_micronumpy:
         code += "#include <pypy_numpy.h> /* api.py line 1290 */\n"
-    code  += "\n".join(functions)
 
     eci = build_eci(code, use_micronumpy, translating=True)
     space.fromcache(State).install_dll(eci)