[pypy-dev] src/pypy/module/test/test_sysmodule.py

Christian Tismer tismer at stackless.com
Tue Jul 6 09:52:50 CEST 2004


Laura Creighton wrote:

>     def test_sys_in_modules(self):
>         import sys
>         modules = sys.modules
>         self.failUnless('sys' in modules, "An entry for sys "
>                                         "is not in sys.modules.")

I see the problem, although it's perfectly fine Python.

...

> My poor program converts them to:
> 
> 
>     def test_sys_in_modules(self):
>         import sys
>         modules = sys.modules
>         assert 'sys' in modules, "An entry for sys "
>                                         "is not in sys.modules."
> 
> I propose we consider src/pypy/module/test/test_sysmodule.py broken, and we fix that
> file, rather than make my program wrap them in parentheses.
> 
> Any objections?

Maybe the test is inconvenient to parse, but by no means
broken. The simplest fix would probably be to emit a "\"
continuation at the line end, and everything is fine.

ciao - chris
-- 
Christian Tismer             :^)   <mailto:tismer at stackless.com>
Mission Impossible 5oftware  :     Have a break! Take a ride on Python's
Johannes-Niemeyer-Weg 9a     :    *Starship* http://starship.python.net/
14109 Berlin                 :     PGP key -> http://wwwkeys.pgp.net/
work +49 30 89 09 53 34  home +49 30 802 86 56  mobile +49 173 24 18 776
PGP 0x57F3BF04       9064 F4E1 D754 C2FF 1619  305B C09C 5A3B 57F3 BF04
      whom do you want to sponsor today?   http://www.stackless.com/




More information about the Pypy-dev mailing list