[pypy-dev] Re: [pypy-svn] r8426 - in pypy/branch/src-typedunwrap/pypy: interpreter/test objspace

[holger krekel]

Hi Samuele, 

i think in the tests you checked in there are "assert"s missing ... 
for example, 

On Wed, Jan 19, 2005 at 20:34 +0100, pedronis at codespeak.net wrote:
> Author: pedronis
> Date: Wed Jan 19 20:34:37 2005
> New Revision: 8426
> 
> Modified:
>    pypy/branch/src-typedunwrap/pypy/interpreter/test/test_gateway.py
>    pypy/branch/src-typedunwrap/pypy/objspace/trivial.py
> +        def g3(space, w_a, w_b):
> +            return space.add(w_a, w_b)        
> +        app_g3 = gateway.interp2app_temp(g3,
> +                                         unwrap_spec=[gateway.ObjSpace,
> +                                                      gateway.W_Root,
> +                                                      gateway.W_Root])
> +        w_app_g3 = space.wrap(app_g3) 
> +        self.space.eq_w(
> +            space.call(w_app_g3, 
> +                       space.newtuple([w('foo'), w('bar')]),
> +                       space.newdict([])),
> +            w('foobar'))

this does not test equality (but it at least checks that it doesn't
raise an unexpected exception :-) 

cheers, 

    holger