[pypy-dev] Re: [pypy-svn] r11817 - in pypy/dist/pypy/lib: . test2

holger krekel hpk at trillke.net
Wed May 4 14:55:02 CEST 2005


Hi Anders, 

also for the sake of others a public comment on 
your checkin. 

On Mon, May 02, 2005 at 21:32 +0200, ale at codespeak.net wrote:
> Author: ale
> Date: Mon May  2 21:32:31 2005
> New Revision: 11817
> 
> Added:
>    pypy/dist/pypy/lib/test2/test_codeccallbacks.py

This is not the right place to add modified CPython's 
regression tests anymore.  Modified regression tests should 
go to 

    lib-python/modified-2.3.4/test/

and they should be copied from the non-modified 2.3.4 
directory instead of simply adding them, btw. This allows
us to trace the history of the modified file much better
(a simple 'svn log test_codeccallbacks.py' shows where
it came from. 

The pypy/lib/test2 directory should only contain interpreter
level tests that can load our pypy/lib implementations simply
like so: 

    from pypy.lib import _codecs  # this should just work when
                                  # run with test_all.py /
                                  # py.test 

    def test_pytest_style(): 
        assert ... # test functionality at CPython-level 
                   # to make sure it basically works 

The advantage of writing tests at this level is that
they run fast because they run directly on CPython. 
You should never copy regression (or unittest-style) 
tests to lib/test2, though. 

If you have any questions, don't hesitate to grab 
any of us on #pypy or here on pypy-dev. 

cheers, 

    holger



More information about the Pypy-dev mailing list