[pypy-dev] Re: [pypy-svn] r18166 - pypy/dist/pypy/translator/tool/pygame

[Armin Rigo]

Hi Carl,

On Tue, Oct 04, 2005 at 09:48:33PM +0200, cfbolz at codespeak.net wrote:
> Log:
> I guess the redraw should be done _after_ the reload.
> 
> 
> Modified: pypy/dist/pypy/translator/tool/pygame/graphdisplay.py
> ==============================================================================
> --- pypy/dist/pypy/translator/tool/pygame/graphdisplay.py	(original)
> +++ pypy/dist/pypy/translator/tool/pygame/graphdisplay.py	Tue Oct  4 21:48:32 2005
> @@ -420,8 +420,8 @@
>  
>      def reload(self):
>          self.setstatusbar('reloading...')
> -        self.redraw_now()
>          self.layout.request_reload()
> +        self.redraw_now()
>  
>      def setstatusbar(self, text, fgcolor=None, bgcolor=None):
>          info = (text, fgcolor or self.STATUSBAR_FGCOLOR, bgcolor or self.STATUSBAR_BGCOLOR)

No, it was intended to be before, so that the "reloading..." would show
up before the new page starts to be computed.  Another redrawing occurs
automatically anyway, done by the main loop that called reload() --
hence the redraw_*now*() in the middle.


Armin