[pypy-dev] [pypy-svn] r33236 - pypy/dist/pypy/objspace/test

[Aurélien Campéas]

On Thu, Oct 12, 2006 at 07:58:29PM +0200, Maciek Fijalkowski wrote:
> auc at codespeak.net wrote:
> 
> >Author: auc
> >Date: Thu Oct 12 19:24:38 2006
> >New Revision: 33236
> >
> >Modified:
> >   pypy/dist/pypy/objspace/test/test_logicobjspace.py
> >Log:
> >some needed adjustement (most notably, removed explicit scheduling calls)
> >
> >
> >Modified: pypy/dist/pypy/objspace/test/test_logicobjspace.py
> >==============================================================================
> >--- pypy/dist/pypy/objspace/test/test_logicobjspace.py	(original)
> >+++ pypy/dist/pypy/objspace/test/test_logicobjspace.py	Thu Oct 12 19:24:38 2006
> >@@ -6,6 +6,11 @@
> >     # we might be called from _test_logic_build
> >     # if not, check your paths
> > 
> >+try:
> >+    is_interpreted()
> >+except:
> >+    def is_interpreted(): return True
> >+
> > 
> >  
> >
> try:
>     from pypy.conftest import gettestobjspace
>     from py.test import skip
> except ImportError:
>     pass
>     # we might be called from _test_logic_build
>     # if not, check your paths
> 
> try:
>     is_interpreted()
> except:
>     def is_interpreted(): return True
> 
> This is really cool kind of code. If we cannot import pypy, # check your 
> paths is in comment (no print, nothing). If we cannot import py.test, we 
> probably won't have is_interpreted, so if is_interpreted(): 

Wrong. Ok this deserves an explanation : whenever we want to test a
pypy logic build, using _test_logic_build.py, is_interpreted is
defined and returns False ... (yes it is not too explicit nor pretty).

> py.test.skip("dsa") will just break. And simply calling py.test 
> test_logicobjspace.py fails. (It should skip if there are no blablabla 
> available).

What are you trying to do ?

> 
> This attempts of having broken tests makes py.test work harder (because 
> I always have to check if tests are broken by default or not).
> 

Please change the tone of your remarks.