[pypy-dev] Compiling pypy with python2.5

Armin Rigo arigo at tunes.org
Fri Mar 23 21:48:33 CET 2007


Hi,

On Fri, Mar 23, 2007 at 10:29:11AM -0400, Scott Dial wrote:
> Amaury Forgeot d'Arc wrote:
> > 4/ 5/ Easy corrections (not specific to 2.5) while trying the --jit
> > option on Windows: platform.machine() is empty on my machine, and
> > codebuf_nt is expected to export a PTR type.
> 
> I noticed this same problem and your patch is virtually identical to 
> mine. I've run the test suite with this and it seems to be a positive 
> change (as in I actually run more tests than I have in the past). So, I 
> endorse this part of the patch.

Checked this part in, thanks.

We should maybe try a couple of Linux translations with the 2.5-relevant
changes to see if they basically work there too, and apply them in this
case.

Amaury, the import from 'pypy.lib.struct' that your patch introduced in
an 'app_*' module looks suspicious...  I'm not sure why we are not
automatically picking up struct.py from pypy/lib/ from app-level code.


A bientot,

Armin



More information about the Pypy-dev mailing list