[pypy-dev] [pypy-svn] r48350 - pypy/dist/pypy/objspace/flow

Christian Tismer tismer at stackless.com
Thu Nov 8 20:11:40 CET 2007


Armin Rigo wrote:
> Hi Christian,
> 
> On Wed, Nov 07, 2007 at 02:20:41PM +0100, Christian Tismer wrote:
>>> could you please write a couple of tests for this? It's very hard to see 
>>> what this code is doing and whether it is broken without tests for its 
>>> functionality.
>> It is just allowing for less than 4 arguments in __import__.
>> Maybe there is a more elegant/bvious way?
> 
> The point is that if it's untested, the next time someone needs to
> refactor something around this file, your un-checked-in experiments are
> going to break, and everybody is going to feel unhappy about it.  So,
> can you invest a little time now to avoid long discussions later?
> Thanks!

understood and done yesterday, alreasy

ciao - chris
-- 
Christian Tismer             :^)   <mailto:tismer at stackless.com>
tismerysoft GmbH             :     Have a break! Take a ride on Python's
Johannes-Niemeyer-Weg 9A     :    *Starship* http://starship.python.net/
14109 Berlin                 :     PGP key -> http://wwwkeys.pgp.net/
work +49 30 802 86 56  mobile +49 173 24 18 776  fax +49 30 80 90 57 05
PGP 0x57F3BF04       9064 F4E1 D754 C2FF 1619  305B C09C 5A3B 57F3 BF04
       whom do you want to sponsor today?   http://www.stackless.com/



More information about the Pypy-dev mailing list