[pypy-dev] PPC64 JIT test_ppc.py tests fixed and working

Sven Hager Sven.Hager at uni-duesseldorf.de
Fri Aug 19 11:39:24 CEST 2011


On 08/18/2011 09:51 PM, David Edelsohn wrote:
> Sven,
>
> With the attached patch, all of the ppc/ppcgen/test/test_ppc.py tests
> pass except for test_call_function that I skip while I debug it.
>
> I updated ppc_assembler.py:load_from() to load a full 64 bit value on
> 64 bit systems.  It is not exactly right because I need to fix the
> signed offset compensation code, but it allows the test to pass.
>
> The multiply tests were failing because the tests perform a signed
> comparison and the result of PPC 32 bit multiply instructions are not
> implicitly sign extended.  I sign extend the results on PPC64 and they
> now pass.
>
> test_load_and_store needs to use load_dword on PPC64 to load the
> addresses into r8 and r9.
>
> test_ld needs to allocate a 64 bit long, not a 32 bit int, and the
> address needs to be loaded with load_dword.
>
> Thanks, David
Hello David,

your recent changes have been added.
Great to see so many tests in ppcgen/test pass. =)

Best regards,
Sven


More information about the pypy-dev mailing list