[pypy-dev] [pypy-commit] pypy reflex-support: Remove elidable_promote that made the translation choke.

[Antonio Cuni]

Hi Wim,

On 16/08/11 19:47, wlav wrote:
> Author: Wim Lavrijsen<WLavrijsen at lbl.gov>
> Branch: reflex-support
> Changeset: r46550:17b6f87c70bc
> Date: 2011-08-16 10:54 -0700
> http://bitbucket.org/pypy/pypy/changeset/17b6f87c70bc/
>
> Log:	Remove elidable_promote that made the translation choke.
>
> diff --git a/pypy/module/cppyy/interp_cppyy.py b/pypy/module/cppyy/interp_cppyy.py
> --- a/pypy/module/cppyy/interp_cppyy.py
> +++ b/pypy/module/cppyy/interp_cppyy.py
> @@ -296,7 +296,6 @@
>       def is_static(self):
>           return self.space.newbool(self._is_static)
>
> -    @jit.elidable_promote()
>       def _get_offset(self, w_cppinstance):
>           cppinstance = self.space.interp_w(W_CPPInstance, w_cppinstance, can_be_None=True)
>           if cppinstance:

are you sure that you really want to kill this promote? I suspect that it 
makes accessing to C++ fields much slower, because it has to recalculate the 
offset every time.

ciao,
Anto