[pypy-dev] [pypy-commit] pypy default: (arigo, bivab) implement longlong2float and float2longlong in a way that is more close to the C standard. On ARM/32bit this code was causing a reodering of instructions that filled one of the two words with

Antonio Cuni anto.cuni at gmail.com
Tue Jun 7 16:02:13 CEST 2011


On 07/06/11 15:38, Armin Rigo wrote:
> That change was not about portability, but about C compilers getting
> too clever at optimizing.  These two functions are (supposed) to be
> only used on machines with 8-byte long longs and doubles.  I could add
> an assert, checking that sizeof(double) == sizeof(long long) == 8.

yes, that sounds like a good idea.  Not that there are any machine around
where the assert would fail, AFAIK, but better to play on the safe side.

ciao,
Anto


More information about the pypy-dev mailing list