[pypy-dev] jvm-improvements branch

Armin Rigo arigo at tunes.org
Sun Aug 12 10:37:28 CEST 2012


Hi Michal,

On Wed, Aug 1, 2012 at 9:20 PM, Michal Bendowski <michal at bendowski.pl> wrote:
> 3. If my code from jvm-improvements looks good I would love to get it merged
> into default, to close one chapter of work (a working rjvm module) and start
> working on whatever's next. Can someone take a look?

I did a review of your work based only on "does it look like it breaks
anything outside of JVM/CLI".  I have only one comment: the
ctypes_configure package should not contain any "import pypy.xxx".
Apart from that, it looks like it wouldn't break anything so I'm fine
if this is merged.


A bientôt,

Armin.


More information about the pypy-dev mailing list