[pypy-dev] [pypy-commit] pypy default: TEMPORARY: put a limit (4 by default) on the number of "cancelled,

[Hakan Ardo]

Hi,
check out the test comited in fff6b491e07d, it tests a fallback in
unroll.py that we dont realy want to ocure by injecting an extra
optimization stage that generates the issue we want to avoid.

On Fri, Jan 13, 2012 at 6:54 PM, Armin Rigo <arigo at tunes.org> wrote:
> Hi,
>
> On Fri, Jan 13, 2012 at 13:01, Carl Friedrich Bolz <cfbolz at gmx.de> wrote:
>> Yes, this breaks Pyrolog. That's fine, I can probably just increase the
>> number. Could you write a test for this commit, though?
>
> It's a bit hard...  I don't have a good enough understanding of the
> reason for which we get cancellations.  But I fear that we're going to
> get the following: even if we manage to reproduce the issue in a test,
> the next step will be "ah, but in this case we should obviously do
> this or that instead of failing 4 times in a row".  Then we do it.
> And then the test is no longer a test for the original commit...
>
>
> A bientôt,
>
> Armin.
> _______________________________________________
> pypy-dev mailing list
> pypy-dev at python.org
> http://mail.python.org/mailman/listinfo/pypy-dev



-- 
Håkan Ardö