[pypy-dev] [pypy-commit] pypy win_ffi: fix test for jit

Antonio Cuni anto.cuni at gmail.com
Sat Jun 2 11:54:14 CEST 2012


Hello Matti,

On 06/01/2012 03:25 PM, mattip wrote:

> @@ -551,6 +552,9 @@
>              except ValueError, e:
>                  assert e.message == 'Procedure called with not enough ' + \
>                       'arguments (8 bytes missing) or wrong calling convention'
> +            except LLException:
> +                #jitted code raises this
> +                pass
>              else:
>                  assert 0, 'wrong calling convention should have raised'

I think you should at least check that the LLException you get is of the right
type, to avoid hiding an unrelated one you might get by chance.

ciao,
Anto


More information about the pypy-dev mailing list