[pypy-dev] [pypy-commit] pypy default: relaxing int vs long

[Christian Tismer]

Hi Amaury,

This is debatable. In this particular case it makes in fact no sense, but in general, we need to stop distinguishing int and long. Instead, a range check is needed to determine an int. 

Sent from my Ei4Steve

On Mar 13, 2012, at 5:25, "Amaury Forgeot d'Arc" <amauryfa at gmail.com> wrote:

> Hi Christian,
> 
> The changeset 8abd5883fa0c looks wrong to me:
> http://mail.python.org/pipermail/pypy-commit/2012-March/060785.html
> 
> diff --git a/pypy/interpreter/test/test_compiler.py
> b/pypy/interpreter/test/test_compiler.py
> --- a/pypy/interpreter/test/test_compiler.py
> +++ b/pypy/interpreter/test/test_compiler.py
> @@ -794,7 +794,7 @@
>     def test_tuple_constants(self):
>         ns = {}
>         exec "x = (1, 0); y = (1L, 0L)" in ns
> -        assert isinstance(ns["x"][0], int)
> +        assert isinstance(ns["x"][0], (int, long))
>         assert isinstance(ns["y"][0], long)
> 
> Why would x[0] be a long? isn't it an int constant?
> 
> -- 
> Amaury Forgeot d'Arc