[pypy-dev] [pypy-commit] pypy default: Enable inlining into the thread module so that Lock.acquire/release have a sane calling convention

[Antonio Cuni]

Hi Alex,
I think that this commit should come with a test_pypy_c test as well.

ciao,
Anto

On 04/09/13 00:03, alex_gaynor wrote:
> Author: Alex Gaynor <alex.gaynor at gmail.com>
> Branch:
> Changeset: r66780:a3e9a5394648
> Date: 2013-09-03 16:02 -0700
> http://bitbucket.org/pypy/pypy/changeset/a3e9a5394648/
>
> Log:	Enable inlining into the thread module so that Lock.acquire/release
> 	have a sane calling convention
>
> diff --git a/pypy/module/pypyjit/policy.py b/pypy/module/pypyjit/policy.py
> --- a/pypy/module/pypyjit/policy.py
> +++ b/pypy/module/pypyjit/policy.py
> @@ -109,7 +109,8 @@
>                          'posix', '_socket', '_sre', '_lsprof', '_weakref',
>                          '__pypy__', 'cStringIO', '_collections', 'struct',
>                          'mmap', 'marshal', '_codecs', 'rctime', 'cppyy',
> -                       '_cffi_backend', 'pyexpat', '_continuation', '_io']:
> +                       '_cffi_backend', 'pyexpat', '_continuation', '_io',
> +                       'thread']:
>               if modname == 'pypyjit' and 'interp_resop' in rest:
>                   return False
>               return True
> diff --git a/pypy/module/pypyjit/test/test_policy.py b/pypy/module/pypyjit/test/test_policy.py
> --- a/pypy/module/pypyjit/test/test_policy.py
> +++ b/pypy/module/pypyjit/test/test_policy.py
> @@ -45,6 +45,10 @@
>       from pypy.module._io.interp_bytesio import W_BytesIO
>       assert pypypolicy.look_inside_function(W_BytesIO.seek_w.im_func)
>
> +def test_thread():
> +    from pypy.module.thread.os_lock import Lock
> +    assert pypypolicy.look_inside_function(Lock.descr_lock_acquire.im_func)
> +
>   def test_pypy_module():
>       from pypy.module._collections.interp_deque import W_Deque
>       from pypy.module._random.interp_random import W_Random
> _______________________________________________
> pypy-commit mailing list
> pypy-commit at python.org
> https://mail.python.org/mailman/listinfo/pypy-commit
>