[pypy-dev] Fwd: Re: Adding init/variables to W_Root

Armin Rigo armin.rigo at gmail.com
Fri Jan 13 06:34:30 EST 2017


Hi,

On 12 January 2017 at 03:35, Frank Wang <frankw at mit.edu> wrote:
> Good catch! I was just trying to get something to work, but it seems like
> you found another bug. I am now checking if it is None:

No, I think these latest changes don't do anything.  The error message
says: you are storing in the rb_flags attribute something that is
sometimes a dict, and sometimes an instance of W_Root.  Check if there
is somewhere else a subclass of W_Root with its own rb_flags attribute
which would be set to a W_Root.  Then you'd get a crash using that
subclass, also untranslated, simply because 'rb_flags' is supposed to
be two different things.  To be on the safe side, you should change
the name of the attribute in W_Root from rb_flags to something much
more obscure like "_frank_rb_flags".


A bientôt,

Armin.


More information about the pypy-dev mailing list