[pypy-issue] [issue785] Reduce-like functions for micronumpy

Alex Gaynor tracker at bugs.pypy.org
Sun Jul 10 22:36:16 CEST 2011


Alex Gaynor <alex.gaynor at gmail.com> added the comment:

a) You have some 8 space indents in there, please 4 space everywhere

b) that reduce_one function is getting large and scary, is there any reason it 
can't be split up into a few seperate ones, it looks like the cases are somewhat 
distinct.  Otherwise looks ok to me.

----------
nosy: +agaynor

________________________________________
PyPy bug tracker <tracker at bugs.pypy.org>
<https://bugs.pypy.org/issue785>
________________________________________


More information about the pypy-issue mailing list