[pypy-issue] [issue912] ZipFile.read() leaks file handles

[Tyler Kennedy]

Tyler Kennedy <tk at tkte.ch> added the comment:

Applying the patch breaks it:


Traceback (most recent call last):
  File "app_main.py", line 53, in run_toplevel
  ...
  File "/Users/tyler/Github/Helicon/helicon/jarfile.py", line 32, in __init__
    self.files = dict((f, zp.read(f)) for f in zp.namelist())
  File "/Users/tyler/Github/Helicon/helicon/jarfile.py", line 32, in <genexpr>
    self.files = dict((f, zp.read(f)) for f in zp.namelist())
  File "/usr/local/Cellar/pypy/1.6.0/lib-python/2.7/zipfile.py", line 876, in 
read
    return fp.read()
  File "/usr/local/Cellar/pypy/1.6.0/lib-python/2.7/zipfile.py", line 657, in 
close
    super().close()
TypeError: __new__() takes at least 2 arguments (1 given)

________________________________________
PyPy bug tracker <tracker at bugs.pypy.org>
<https://bugs.pypy.org/issue912>
________________________________________