[pypy-issue] [issue1220] Improving readability of generated .c code

Amaury Forgeot d Arc tracker at bugs.pypy.org
Sat Jul 21 14:25:15 CEST 2012


Amaury Forgeot d Arc <amauryfa at gmail.com> added the comment:

In general, +100.
Can you create a branch and commit your patch there?

I have some remarks already, but nothing crucial:
- I'm a bit concerned by the increased memory usage. Those 'comment' operations could be controlled by a 
translation option.
- Generated C source code is more indented than before. That's an improvement of course, but maybe the tabs 
should be replaced by 4 spaces.
- RPython source lines in comments have too much spaces on the left.
- RPython source file name should be relative (to pypy root dir). I'm not sure I want to show the directory 
structure of my local machine.

----------
nosy: +afa

________________________________________
PyPy bug tracker <tracker at bugs.pypy.org>
<https://bugs.pypy.org/issue1220>
________________________________________


More information about the pypy-issue mailing list