[pypy-issue] [issue1406] pyopenssl-0.13 test suite trips up pypy in test_crypto.py test_ssl.py

Maciej Fijalkowski fijall at gmail.com
Sat Feb 23 12:01:28 CET 2013


On Sat, Feb 23, 2013 at 9:06 AM, Ian Delaney <tracker at bugs.pypy.org> wrote:
>
> Ian Delaney <della5 at iinet.com.au> added the comment:
>
> ok thx fijal.  I fixed the first test inside 20 minutes by swtiching to the
> Attribute Error.  The second 2 tests in test_ssl.py appear a totally different
> matter.
> Firstly are you suggesting the same applies here?  The file has a myriad of
> entries of TypeError and despite extended efforts I couldn't find the source of
> allocating the TypeError to the tests.
> Secondly, the tests pass by following the prompt of the error msg. In
>
> count = server.send(memoryview(b('xy')))
> &&
> server.sendall(memoryview(b('x')))
>
> substituting memoryview with buffer in pypy sees them pass.  This to me isn't a
> fix of the test, it's changing the test beyond its intent.
> Do you know what a memoryview is?  In the test_ssl.py the making or defining of
> memoryview loses me all together.  A buffer is a known structure, a memoryview
> I've never heard of.
>
> ________________________________________
> PyPy bug tracker <tracker at bugs.pypy.org>
> <https://bugs.pypy.org/issue1406>
> ________________________________________

No, I didn't say that :)

I would need to investigate


More information about the pypy-issue mailing list