[pypy-issue] Issue #1915: SSL getpeercert(binary_form=True) not returning binary (pypy/pypy)

Corey Farwell issues-reply at bitbucket.org
Sat Nov 1 01:14:48 CET 2014

New issue 1915: SSL getpeercert(binary_form=True) not returning binary

Corey Farwell:

Disclaimer: I don't know much about sockets/SSL, so I don't really know what I'm doing

Running into a build issue [here](https://travis-ci.org/shazow/urllib3/builds/39609537) with [urllib3](https://github.com/shazow/urllib3)

As an example, running

nosetests -s test.with_dummyserver.test_https:TestHTTPS.test_verify_none_and_good_fingerprint

With Python 3.2.5 (cpython), the test passes


Python 3.2.5 (b2091e973da69152b3f928bfaabd5d2347e6df46, Oct 22 2014, 02:19:03)
[PyPy 2.4.0 with GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.54)]

the test fails. [This line in particular](https://github.com/shazow/urllib3/blob/master/urllib3/connection.py#L240) is problematic. `self.sock.getpeercert(binary_form=True)` is returning a string even though it shouldn't

More information about the pypy-issue mailing list