[pypy-issue] Issue #2105: [patch] tool/release/package.py does not work with --builddir (pypy/pypy)

David Naylor issues-reply at bitbucket.org
Sun Aug 2 17:08:22 CEST 2015


New issue 2105: [patch] tool/release/package.py does not work with --builddir
https://bitbucket.org/pypy/pypy/issues/2105/patch-tool-release-packagepy-does-not-work

David Naylor:

When running package.py with a custom --builddir command it gives the following error:
```
# python2.7package.py --without-cffi --builddir $BUILDDIR

Traceback (most recent call last):
  File "/usr/local/home/dbn/ports/ports/lang/pypy/work/pypy-pypy-295ee98b6928/pypy/tool/release/package.py", line 365, in <module>
    retval, _ = package(*sys.argv[1:])
  File "/usr/local/home/dbn/ports/ports/lang/pypy/work/pypy-pypy-295ee98b6928/pypy/tool/release/package.py", line 344, in package
    return create_package(basedir, options, **kwds)
  File "/usr/local/home/dbn/ports/ports/lang/pypy/work/pypy-pypy-295ee98b6928/pypy/tool/release/package.py", line 139, in create_package
    pypydir = builddir.ensure(name, dir=True)
AttributeError: 'str' object has no attribute 'ensure'
```

The attached patch fixes this by ensuring the builddir variable is of type py.path.  




More information about the pypy-issue mailing list