[pytest-dev] thanking for PRs?

[Florian Bruhin]

* holger krekel <holger at merlinux.eu> [2015-12-11 14:29:35 +0000]:
> I was wondering about the practise to have PR authors add themselves
> to AUTHORS and CHANGELOG.  The latter particularly is a bit odd, i.e.
> to thank yourself for submitting a PR.

I agree - I've even been asked on Twitter before from some pytest user
about this.

> What do you all think about having the merger do this last bit
> (changelog entry)?  AUTHORS can also be usually obtained from the
> history so that contributors can concentrate on tests, code and
> possibly docs.

I have a more radical view: Do we really want "thanks" in the
changelog at all? IMHO they're just unnecessary noise. We already
express our gratitude as a PR comment and we give credit by listing
people in AUTHORS, so I'd rather not have this in the changelog as
well.

The job of it, after all, is for someone to view *what changed*. If I
want to know *who* changed something, I can easily look it up.

Florian

-- 
http://www.the-compiler.org | me at the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
         I love long mails! | http://email.is-not-s.ms/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mail.python.org/pipermail/pytest-dev/attachments/20151211/f181ce6f/attachment.sig>