[pytest-dev] thanking for PRs?
florian.schulze at gmx.net
Sun Dec 13 02:32:33 EST 2015
I just list the usernames after the change and if the user contributed
for the first time, the fullname as well. See this for example:
On 11 Dec 2015, at 16:14, holger krekel wrote:
> On Fri, Dec 11, 2015 at 14:48 +0000, Bruno Oliveira wrote:
>> On Fri, Dec 11, 2015 at 12:30 PM holger krekel <holger at merlinux.eu>
>>> I was wondering about the practise to have PR authors add themselves
>>> to AUTHORS and CHANGELOG. The latter particularly is a bit odd,
>>> to thank yourself for submitting a PR. What do you all think about
>>> having the merger do this last bit (changelog entry)? AUTHORS
>>> can also be usually obtained from the history so that contributors
>>> can concentrate on tests, code and possibly docs.
>> Often when I merge a PR I do so using GitHub's web interface because
>> not at my workstation so I don't have the code checked out, but it is
>> enough to also use GitHub's web interface to edit and commit the
>> file directly to master after the merge, so I'm not against changing
>> policy regarding the CHANGELOG.
>> About AUTHORS, if we are changing things, IMHO we can delete that
>> file and
>> add a link to the README pointing to
>> https://github.com/pytest-dev/pytest/graphs/contributors or
> I think the source distro should directly contain the list of authors.
> But we can also add links to the github from the web page.
> As to Florian's view of not thanking: it feels different for
> some authors to be mentioned by name when a release announce
> is sent around or in the changelog. Also i think it's interesting
> to know who changed something. Doing blame/annotate is a different
> thing for different purposes IMO.
>>> my 2c,
>>> pytest-dev mailing list
>>> pytest-dev at python.org
> about me: http://holgerkrekel.net/about-me/
> contracting: http://merlinux.eu
> pytest-dev mailing list
> pytest-dev at python.org
More information about the pytest-dev