[pytest-dev] merging PR freedom
Floris Bruynooghe
flub at devork.be
Wed Jun 10 11:44:22 CEST 2015
On 3 June 2015 at 22:53, holger krekel <holger at merlinux.eu> wrote:
> Hi Ronny and all other commiters :)
>
> i realize that from time to time you only "approve" a PR but don't
> merge it. Please feel more free to just merge.
I guess it's partially habit, sometimes just giving other people the
chance to comment. The habit part is because at work we've settled
into the workflow where reviewers only ever approve and only the PR
submitter merges their own PR. But things probably speed up when
merging right away so I'm happy with that too.
Regards,
Floris
More information about the pytest-dev
mailing list