From nicoddemus at gmail.com Mon Dec 5 09:46:30 2016 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Mon, 05 Dec 2016 14:46:30 +0000 Subject: [pytest-dev] pytest 3.0.5 released Message-ID: pytest 3.0.5 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The changelog is available at http://doc.pytest.org/en/latest/changelog.html . Thanks to all who contributed to this release, among them: * Ana Vojnovic * Bruno Oliveira * Daniel Hahler * Duncan Betts * Igor Starikov * Ismail * Luke Murphy * Ned Batchelder * Ronny Pfannschmidt * Sebastian Ramacher * nmundar Happy testing, The pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Tue Dec 6 02:43:37 2016 From: opensource at ronnypfannschmidt.de (Ronny Pfannschmidt) Date: Tue, 6 Dec 2016 08:43:37 +0100 Subject: [pytest-dev] [proposal] introducing attrs to the codebase Message-ID: <20161206084337.218b6fec@ronny-ownpc> Hi all, i'd like to introduce https://pypi.python.org/pypi/attrs as a dependency, its a fairly usefull library that takes away quite some boilerplate and common error cause while automatically adding repr, comparators and similar small details to python classes. I have used it in a number of personal projects, and dont want to miss it by now. -- Ronny From nicoddemus at gmail.com Tue Dec 6 04:52:25 2016 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Tue, 06 Dec 2016 09:52:25 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: <20161206084337.218b6fec@ronny-ownpc> References: <20161206084337.218b6fec@ronny-ownpc> Message-ID: Hi Ronny, Could you list the classes which you think would be changed to use 'attrs'? I'm not against adding another dependency if it can help us maintain the codebase. Also, introducing a new dependency should be done in `3.1.0`, not in a patch release. Cheers, Bruno. On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < opensource at ronnypfannschmidt.de> wrote: > Hi all, > > i'd like to introduce https://pypi.python.org/pypi/attrs as a > dependency, > > its a fairly usefull library that takes away quite some boilerplate and > common error cause while automatically adding repr, comparators and > similar small details to python classes. > > I have used it in a number of personal projects, and dont want to miss > it by now. > > -- Ronny > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From raphael at hackebrot.de Tue Dec 6 05:57:28 2016 From: raphael at hackebrot.de (Raphael Pierzina) Date: Tue, 6 Dec 2016 10:57:28 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> Message-ID: <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Hey there, I don?t mind adding a dependency as long as there is a need for it. +1 The problem I see with ?attrs? as it stands today, is that it does not support Python 2.6 whereas pytest does. So we probably want to get https://github.com/pytest-dev/pytest/issues/1273 in before adding ?attrs? as a dependency. I?m not up-to-date with how things are in pip as to dropping Python 2.6 compatibility. I can?t seem to find a ticket on the pip issue tracker. Best, Raphael > On 06 Dec 2016, at 09:52, Bruno Oliveira wrote: > > Hi Ronny, > > Could you list the classes which you think would be changed to use 'attrs'? I'm not against adding another dependency if it can help us maintain the codebase. Also, introducing a new dependency should be done in `3.1.0`, not in a patch release. > > Cheers, > Bruno. > > On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt > wrote: > Hi all, > > i'd like to introduce https://pypi.python.org/pypi/attrs as a > dependency, > > its a fairly usefull library that takes away quite some boilerplate and > common error cause while automatically adding repr, comparators and > similar small details to python classes. > > I have used it in a number of personal projects, and dont want to miss > it by now. > > -- Ronny > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Tue Dec 6 06:15:23 2016 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Tue, 06 Dec 2016 11:15:23 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Oh good point Raphael. Here's the link for the discussion about pip dropping Python 2.6: https://github.com/pypa/pip/issues/3955 Cheers, Bruno On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina wrote: > Hey there, > > I don?t mind adding a dependency as long as there is a need for it. +1 > > The problem I see with ?attrs? as it stands today, is that it does not > support Python 2.6 whereas pytest does. So we probably want to get > https://github.com/pytest-dev/pytest/issues/1273 in before adding ?attrs? > as a dependency. I?m not up-to-date with how things are in pip as to > dropping Python 2.6 compatibility. I can?t seem to find a ticket on the pip > issue tracker. > > Best, > Raphael > > On 06 Dec 2016, at 09:52, Bruno Oliveira wrote: > > Hi Ronny, > > Could you list the classes which you think would be changed to use > 'attrs'? I'm not against adding another dependency if it can help us > maintain the codebase. Also, introducing a new dependency should be done in > `3.1.0`, not in a patch release. > > Cheers, > Bruno. > > On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < > opensource at ronnypfannschmidt.de> wrote: > > Hi all, > > i'd like to introduce https://pypi.python.org/pypi/attrs as a > dependency, > > its a fairly usefull library that takes away quite some boilerplate and > common error cause while automatically adding repr, comparators and > similar small details to python classes. > > I have used it in a number of personal projects, and dont want to miss > it by now. > > -- Ronny > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ronny.pfannschmidt at redhat.com Tue Dec 6 06:16:27 2016 From: ronny.pfannschmidt at redhat.com (Ronny Pfannschmidt) Date: Tue, 6 Dec 2016 12:16:27 +0100 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> Message-ID: *resend after mistake* Hi Bruno, i was thinking of doing it in the features branch, as far as i can tell it can be applied to all classes of the code/traceback, report and node details as well of a lot of mark related inner details having low cost classes should also ease de-tangling node mark handling and keywords we still should investigate how to use it and if we should vendor it -- Ronny 2016-12-06 10:52 GMT+01:00 Bruno Oliveira : > Hi Ronny, > > Could you list the classes which you think would be changed to use > 'attrs'? I'm not against adding another dependency if it can help us > maintain the codebase. Also, introducing a new dependency should be done in > `3.1.0`, not in a patch release. > > Cheers, > Bruno. > > On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < > opensource at ronnypfannschmidt.de> wrote: > >> Hi all, >> >> i'd like to introduce https://pypi.python.org/pypi/attrs as a >> dependency, >> >> its a fairly usefull library that takes away quite some boilerplate and >> common error cause while automatically adding repr, comparators and >> similar small details to python classes. >> >> I have used it in a number of personal projects, and dont want to miss >> it by now. >> >> -- Ronny >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Tue Dec 6 07:03:53 2016 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Tue, 06 Dec 2016 12:03:53 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: On Tue, Dec 6, 2016 at 9:52 AM Floris Bruynooghe wrote: > > As an aside, if we're happy to introduce more libraries then maybe we > should also consider the standard six package instead of doing our own > stuff, mostly because I'd make it easier for new contributors. > I had this in mind as well. Perhaps it is worth replacing all our custom code with six and see if it is worth it. Created an issue for it: https://github.com/pytest-dev/pytest/issues/2122 Cheers, Bruno. -------------- next part -------------- An HTML attachment was scrubbed... URL: From flub at devork.be Tue Dec 6 06:52:05 2016 From: flub at devork.be (Floris Bruynooghe) Date: Tue, 6 Dec 2016 11:52:05 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Hi, Personally I also don't mind the dependency. Though I know in the past we've had a policy of keeping dependencies to a minimum as well as licenses. Attrs uses MIT as well so that should not be a problem. One thing which does stand out is that attrs is at v16, suggesting they break their API a lot. Since you work with it already I guess you have an idea on whether they've stabilised by now or the changes are not so bad? As an aside, if we're happy to introduce more libraries then maybe we should also consider the standard six package instead of doing our own stuff, mostly because I'd make it easier for new contributors. Regards, Floris On 6 Dec 2016 11:16, "Bruno Oliveira" wrote: Oh good point Raphael. Here's the link for the discussion about pip dropping Python 2.6: https://github.com/pypa/pip/issues/3955 Cheers, Bruno On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina wrote: > Hey there, > > I don?t mind adding a dependency as long as there is a need for it. +1 > > The problem I see with ?attrs? as it stands today, is that it does not > support Python 2.6 whereas pytest does. So we probably want to get > https://github.com/pytest-dev/pytest/issues/1273 in before adding ?attrs? > as a dependency. I?m not up-to-date with how things are in pip as to > dropping Python 2.6 compatibility. I can?t seem to find a ticket on the pip > issue tracker. > > Best, > Raphael > > On 06 Dec 2016, at 09:52, Bruno Oliveira wrote: > > Hi Ronny, > > Could you list the classes which you think would be changed to use > 'attrs'? I'm not against adding another dependency if it can help us > maintain the codebase. Also, introducing a new dependency should be done in > `3.1.0`, not in a patch release. > > Cheers, > Bruno. > > On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < > opensource at ronnypfannschmidt.de> wrote: > > Hi all, > > i'd like to introduce https://pypi.python.org/pypi/attrs as a > dependency, > > its a fairly usefull library that takes away quite some boilerplate and > common error cause while automatically adding repr, comparators and > similar small details to python classes. > > I have used it in a number of personal projects, and dont want to miss > it by now. > > -- Ronny > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > _______________________________________________ pytest-dev mailing list pytest-dev at python.org https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From tinchester at gmail.com Tue Dec 6 07:18:04 2016 From: tinchester at gmail.com (=?UTF-8?Q?Tin_Tvrtkovi=C4=87?=) Date: Tue, 06 Dec 2016 12:18:04 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: Message-ID: Hi, attrs is version 16 since it uses CalVer, not SemVer. Also see: https://attrs.readthedocs.io/en/stable/backward-compatibility.html > Date: Tue, 6 Dec 2016 11:52:05 +0000 > From: Floris Bruynooghe > To: Bruno Oliveira > Cc: pytest-dev at python.org, Raphael Pierzina > Subject: Re: [pytest-dev] [proposal] introducing attrs to the codebase > Message-ID: > rUG1n9euPPm1f5y2g1hhrMPOA at mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > Hi, > > Personally I also don't mind the dependency. Though I know in the past > we've had a policy of keeping dependencies to a minimum as well as > licenses. Attrs uses MIT as well so that should not be a problem. > > One thing which does stand out is that attrs is at v16, suggesting they > break their API a lot. Since you work with it already I guess you have an > idea on whether they've stabilised by now or the changes are not so bad? > > > As an aside, if we're happy to introduce more libraries then maybe we > should also consider the standard six package instead of doing our own > stuff, mostly because I'd make it easier for new contributors. > > Regards, > Floris > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mail at florian-schulze.net Tue Dec 6 07:19:04 2016 From: mail at florian-schulze.net (Florian Schulze) Date: Tue, 06 Dec 2016 13:19:04 +0100 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Hi! The v16 is because it uses time based version numbering. Regards, Florian Schulze On 6 Dec 2016, at 12:52, Floris Bruynooghe wrote: > Hi, > > Personally I also don't mind the dependency. Though I know in the past > we've had a policy of keeping dependencies to a minimum as well as > licenses. Attrs uses MIT as well so that should not be a problem. > > One thing which does stand out is that attrs is at v16, suggesting > they > break their API a lot. Since you work with it already I guess you have > an > idea on whether they've stabilised by now or the changes are not so > bad? > > > As an aside, if we're happy to introduce more libraries then maybe we > should also consider the standard six package instead of doing our own > stuff, mostly because I'd make it easier for new contributors. > > Regards, > Floris > > On 6 Dec 2016 11:16, "Bruno Oliveira" wrote: > > Oh good point Raphael. > > Here's the link for the discussion about pip dropping Python 2.6: > https://github.com/pypa/pip/issues/3955 > > Cheers, > Bruno > > On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina > wrote: > >> Hey there, >> >> I don?t mind adding a dependency as long as there is a need for it. >> +1 >> >> The problem I see with ?attrs? as it stands today, is that it >> does not >> support Python 2.6 whereas pytest does. So we probably want to get >> https://github.com/pytest-dev/pytest/issues/1273 in before adding >> ?attrs? >> as a dependency. I?m not up-to-date with how things are in pip as >> to >> dropping Python 2.6 compatibility. I can?t seem to find a ticket on >> the pip >> issue tracker. >> >> Best, >> Raphael >> >> On 06 Dec 2016, at 09:52, Bruno Oliveira >> wrote: >> >> Hi Ronny, >> >> Could you list the classes which you think would be changed to use >> 'attrs'? I'm not against adding another dependency if it can help us >> maintain the codebase. Also, introducing a new dependency should be >> done in >> `3.1.0`, not in a patch release. >> >> Cheers, >> Bruno. >> >> On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < >> opensource at ronnypfannschmidt.de> wrote: >> >> Hi all, >> >> i'd like to introduce https://pypi.python.org/pypi/attrs as a >> dependency, >> >> its a fairly usefull library that takes away quite some boilerplate >> and >> common error cause while automatically adding repr, comparators and >> similar small details to python classes. >> >> I have used it in a number of personal projects, and dont want to >> miss >> it by now. >> >> -- Ronny >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> >> > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From rpfannsc at redhat.com Tue Dec 6 06:17:53 2016 From: rpfannsc at redhat.com (Ronny Pfannschmidt) Date: Tue, 6 Dec 2016 12:17:53 +0100 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Attrs dropped 2.6 pretty recently, it might be reasonably easy to add/keep the support for the pip timeframe as well on the upstream, i'll check wit the author 2016-12-06 12:15 GMT+01:00 Bruno Oliveira : > Oh good point Raphael. > > Here's the link for the discussion about pip dropping Python 2.6: > https://github.com/pypa/pip/issues/3955 > > Cheers, > Bruno > > On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina > wrote: > >> Hey there, >> >> I don?t mind adding a dependency as long as there is a need for it. +1 >> >> The problem I see with ?attrs? as it stands today, is that it does not >> support Python 2.6 whereas pytest does. So we probably want to get >> https://github.com/pytest-dev/pytest/issues/1273 in before adding >> ?attrs? as a dependency. I?m not up-to-date with how things are in pip as >> to dropping Python 2.6 compatibility. I can?t seem to find a ticket on the >> pip issue tracker. >> >> Best, >> Raphael >> >> On 06 Dec 2016, at 09:52, Bruno Oliveira wrote: >> >> Hi Ronny, >> >> Could you list the classes which you think would be changed to use >> 'attrs'? I'm not against adding another dependency if it can help us >> maintain the codebase. Also, introducing a new dependency should be done in >> `3.1.0`, not in a patch release. >> >> Cheers, >> Bruno. >> >> On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < >> opensource at ronnypfannschmidt.de> wrote: >> >> Hi all, >> >> i'd like to introduce https://pypi.python.org/pypi/attrs as a >> dependency, >> >> its a fairly usefull library that takes away quite some boilerplate and >> common error cause while automatically adding repr, comparators and >> similar small details to python classes. >> >> I have used it in a number of personal projects, and dont want to miss >> it by now. >> >> -- Ronny >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> >> > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric Shander -------------- next part -------------- An HTML attachment was scrubbed... URL: