[pytest-dev] mark fix-up major milestone, please review

[Floris Bruynooghe]

Hi Ronny,

On Mon, Mar 19 2018, Ronny Pfannschmidt wrote:

> Hi everyone,
>
> in https://github.com/pytest-dev/pytest/pull/3317 i introduced a new way to
> store marks and aslo consistently use it (this fixed a few bugs pytest
> dragged along since years)

I've spent a while reading the PR but to be honest it's kind of hard to
know how sane things are.  It looks ok, but I don't have a view of the
larger picture.

Are there somewhere some notes about where the marks come from, what the
problems with them are and the vision of how the problems are going to
be solved and what the end-state will look like?

For example from the current PR it's not obvious how users are meant to
be using marks.  You still apply them using @pytest.mark.name as before,
but how are we supposed to access them?  How are we setting them
pragmatically?

> I also did deprecate markinfo attributes,
> so everyone using them will get deprecation warnings.

That's a lot of people probably.  How long are we giving users for this?

> as far as i'm concerned, markinfo attributes where never ever a correct way
> to handle distinct marks and quite a few bugs in pytest came from using
> combined marks in markinfo instead of distinct marks.

A short summary of these issues would help loads :)



Cheers,
Floris