[pytest-dev] mark fix-up major milestone, please review

[Florian Schulze]

On 20 Mar 2018, at 15:07, Floris Bruynooghe wrote:

> On Tue, Mar 20 2018, Ronny Pfannschmidt wrote:
>
>> 2018-03-20 9:18 GMT+01:00 Floris Bruynooghe <flub at devork.be>:
>>> On Mon, Mar 19 2018, Ronny Pfannschmidt wrote:
>>>> I also did deprecate markinfo attributes,
>>>> so everyone using them will get deprecation warnings.
>>>
>>> That's a lot of people probably.  How long are we giving users for 
>>> this?
>>> ​
>>>
>>
>> ​the support for accessing them can be kept for quite a while,
>> everyone using them will be told to use the new api
>> i would like to remove it at the beginning of 2019
>
> Ok, they're currently marked as "deprecated in 4.0".  So we're not
> releasing 4.0 until then?  Or are we just keeping our options open 
> here
> and extending a deprecation is easier then reducing it?

I think the marker PR already qualifies for a 4.0, so I would extend the 
deprecations.


> Thanks!  Could you give an example of a marker transfer bug?  I've 
> never
> run into those myself so I'm not sure I understand what this is.

In devpi-server we have test classes that inherit from another test 
class. The derived one overwrites one fixture (for example testing 
through nginx or a devpi replica instead of directly against 
devpi-server). Because some of these fixtures are expensive, I want to 
mark the inherited class as "slow". Currently that mark is transferred 
to the base class and there is no other way to mark only the test 
functions on the derived class as slow. So currently the base class is 
also marked as slow. The PR fixes that.

Regards,
Florian Schulze