From asottile+pytest at umich.edu Sat Jan 4 16:22:12 2020 From: asottile+pytest at umich.edu (Anthony Sottile) Date: Sat, 4 Jan 2020 13:22:12 -0800 Subject: [pytest-dev] pytest 4.6.9 released! Message-ID: *note* this release marks the beginning of "community supported 4.6 maintenance" Until January 2020, the pytest core team ported many bug-fixes from the main release into the `4.6-maintenance` branch, with several 4.6.X releases being made along the year. >From now on, the core team will *no longer actively backport patches*, but the `4.6-maintenance` branch will continue to exist so the community itself can contribute patches. The core team will be happy to accept those patches, and make new 4.6.X releases *until mid-2020* (but consider that date as a ballpark, after that date the team might still decide to make new releases for critical bugs). pytest-4.6.9 ======================================= pytest 4.6.9 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The full changelog is available at https://docs.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Anthony Sottile * Bruno Oliveira * Felix Yan * Hugo Happy testing, The pytest Development Team From nicoddemus at gmail.com Mon Jan 6 10:58:07 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Mon, 6 Jan 2020 12:58:07 -0300 Subject: [pytest-dev] Opinions on the looks of the pytest docs Message-ID: Hi everyone, I've tried to send a message here about the current looks of the pytest documentation here, but due to image sizes it was blocked, so I opened an issue instead: https://github.com/pytest-dev/pytest/issues/6402 Everyone is welcome to join the discussion there. Cheers, Bruno -------------- next part -------------- An HTML attachment was scrubbed... URL: From h.goebel at crazy-compilers.com Thu Jan 16 04:25:15 2020 From: h.goebel at crazy-compilers.com (Hartmut Goebel) Date: Thu, 16 Jan 2020 10:25:15 +0100 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? Message-ID: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> Hi, my package layout follows the "Tests as part of application code" [1]: src/mypkg/__init__.py src/mypkg/app.py src/mypkg/test/__init__.py src/mypkg/test/test_hooksample_packaging.py where "__pyinstaller" contains the tests to be picked up. 1. When running "python3 -m pytest src/mypkg/test" NO tests will be collected. 2. I tried moving src/mypkg/test into src/mypkg/test/xxx (one level more): ??? * When running "python3 -m pytest src/mypkg/test", tests will be picked up. ??? * When running "python3 -m pytest src/mypkg/test/xxx" NO will be picked up. What am I going wrong here? Just in case: The actual repo can be found at . [1] http://doc.pytest.org/en/latest/goodpractices.html#tests-as-part-of-application-code -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel at crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From nicoddemus at gmail.com Thu Jan 16 05:30:26 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 16 Jan 2020 07:30:26 -0300 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? In-Reply-To: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> References: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> Message-ID: Hi Harmut, It works for me when I use your repository directly: ? pip install pytest PyInstaller ? python -m pytest src ======================== test session starts ======================== platform win32 -- Python 3.6.8, pytest-5.3.2, py-1.8.1, pluggy-0.13.1 rootdir: C:\Users\bruno\hooksample collected 1 item src\pyi_hooksample\__pyinstaller\t\test_hooksample_packaging.py . [100%] ========================= warnings summary ========================== src/pyi_hooksample/__pyinstaller/t/test_hooksample_packaging.py::test_pyi_hooksample C:\Users\bruno\hooksample\.env36\lib\site-packages\PyInstaller\lib\modulegraph\util.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses import imp -- Docs: https://docs.pytest.org/en/latest/warnings.html =================== 1 passed, 1 warning in 4.87s ==================== But the instructions you wrote don?t fit the repository, so I suspect you have changed the layout since writing your original email. Could you please perhaps pushing to a branch the exact state of your instructions so I can try to reproduce the issue? Thanks! Cheers, Bruno On Thu, Jan 16, 2020 at 6:25 AM Hartmut Goebel wrote: > Hi, > > my package layout follows the "Tests as part of application code" [1]: > > src/mypkg/__init__.py > src/mypkg/app.py > src/mypkg/test/__init__.py > src/mypkg/test/test_hooksample_packaging.py > > where "__pyinstaller" contains the tests to be picked up. > > 1. When running "python3 -m pytest src/mypkg/test" NO tests will be > collected. > > 2. I tried moving src/mypkg/test into src/mypkg/test/xxx (one level more): > > * When running "python3 -m pytest src/mypkg/test", tests will be > picked up. > > * When running "python3 -m pytest src/mypkg/test/xxx" NO will be > picked up. > > What am I going wrong here? > > Just in case: The actual repo can be found at > . > > [1] > > http://doc.pytest.org/en/latest/goodpractices.html#tests-as-part-of-application-code > > -- > > Regards > Hartmut Goebel > > | Hartmut Goebel | h.goebel at crazy-compilers.com | > | www.crazy-compilers.com | compilers which you thought are impossible | > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From h.goebel at crazy-compilers.com Thu Jan 16 09:38:08 2020 From: h.goebel at crazy-compilers.com (Hartmut Goebel) Date: Thu, 16 Jan 2020 15:38:08 +0100 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? In-Reply-To: References: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> Message-ID: <9b24e5cd-1240-1b02-85f1-fe4c535c6ce1@crazy-compilers.com> Hi Bruno, > But the instructions you wrote don?t fit the repository, so I suspect > you have changed the layout since writing your original email. Could > you please perhaps pushing to a branch Sorry, I wanted to list the files in a way easy to understand. Now the repo contains two branches: 1. "one-level-less": test-cases are in src/pyi_hooksample/__pyinstaller ?? pytest src/pyi_hooksample/__pyinstaller ?? -> NO tests will be picked up 2. master: test-cases are in src/pyi_hooksample/__pyinstaller/t (mind the trailing t) ?? pytest src/pyi_hooksample/__pyinstaller/t ?? -> NO tests will be picked up ?? pytest src/pyi_hooksample/__pyinstaller ? # one level above the test ?? -> NO tests will be picked up => When pointing pytest to the package containing the tests, they will NOT be picked up => When pointing pytest to the parent package the tests will be picked up (My aim is to have a layout like in "one-level-less" and point pytest to src/pyi_hooksample/__pyinstaller.) platform linux -- Python 3.7.5, pytest-5.0.1, py-1.8.0, pluggy-0.12.0 plugins: cov-2.7.1, drop-dup-tests-0.1.0, forked-1.0.2, timeout-1.3.3, xdist-1.29.0 -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel at crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From nicoddemus at gmail.com Thu Jan 16 10:45:41 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 16 Jan 2020 12:45:41 -0300 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? In-Reply-To: <9b24e5cd-1240-1b02-85f1-fe4c535c6ce1@crazy-compilers.com> References: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> <9b24e5cd-1240-1b02-85f1-fe4c535c6ce1@crazy-compilers.com> Message-ID: Hi! Thanks for the branches, I managed to reproduce the issue but only after installing the exact same versions of pytest, pluggy, and plugins. The problem is the pytest-drop-dup-tests plugin, if I pass -p no:drop-dup-tests, the test is collected and executed as normal. If you really need to use pytest-drop-dup-tests, please create an issue there and I will take a look later, otherwise just uninstalling is enough for your example to work. Cheers, On Thu, Jan 16, 2020 at 11:38 AM Hartmut Goebel < h.goebel at crazy-compilers.com> wrote: > Hi Bruno, > > > But the instructions you wrote don?t fit the repository, so I suspect > > you have changed the layout since writing your original email. Could > > you please perhaps pushing to a branch > Sorry, I wanted to list the files in a way easy to understand. > Now the repo contains two > branches: > > 1. "one-level-less": test-cases are in src/pyi_hooksample/__pyinstaller > > pytest src/pyi_hooksample/__pyinstaller > -> NO tests will be picked up > > 2. master: test-cases are in src/pyi_hooksample/__pyinstaller/t (mind > the trailing t) > > pytest src/pyi_hooksample/__pyinstaller/t > -> NO tests will be picked up > > pytest src/pyi_hooksample/__pyinstaller # one level above the test > -> NO tests will be picked up > > => When pointing pytest to the package containing the tests, they will > NOT be picked up > > => When pointing pytest to the parent package the tests will be picked up > > > (My aim is to have a layout like in "one-level-less" and point pytest to > src/pyi_hooksample/__pyinstaller.) > > platform linux -- Python 3.7.5, pytest-5.0.1, py-1.8.0, pluggy-0.12.0 > plugins: cov-2.7.1, drop-dup-tests-0.1.0, forked-1.0.2, timeout-1.3.3, > xdist-1.29.0 > > -- > Regards > Hartmut Goebel > > | Hartmut Goebel | h.goebel at crazy-compilers.com | > | www.crazy-compilers.com | compilers which you thought are impossible | > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From h.goebel at crazy-compilers.com Thu Jan 16 12:00:08 2020 From: h.goebel at crazy-compilers.com (Hartmut Goebel) Date: Thu, 16 Jan 2020 18:00:08 +0100 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? In-Reply-To: References: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> <9b24e5cd-1240-1b02-85f1-fe4c535c6ce1@crazy-compilers.com> Message-ID: Hi, Thanks you very much for evaluating this so quickly :-) I was able to work around the issue by uninstalling pytest-drop-dup-tests. Nevertheless I opens an issue there so this doesn't get lost.| | |https://github.com/nicoddemus/pytest-drop-dup-tests/issues/3 | -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel at crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Thu Jan 16 12:12:03 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 16 Jan 2020 14:12:03 -0300 Subject: [pytest-dev] pytest does not collect test-cases - what am I doing wrong? In-Reply-To: References: <21a9eedc-83f2-dd7c-90d7-100acf4eca4d@crazy-compilers.com> <9b24e5cd-1240-1b02-85f1-fe4c535c6ce1@crazy-compilers.com> Message-ID: Hi Hartmut. Sure thing, thanks for creating the issue and maintaining PyInstaller. :) (FWIW in case you didn't know already, we freeze pytest as part of our suite using PyInstaller: https://github.com/pytest-dev/pytest/blob/b91c721262a57ca265eace37daf79475abf4cd91/.github/workflows/main.yml#L86-L89 ) Cheers, Bruno On Thu, Jan 16, 2020 at 2:00 PM Hartmut Goebel wrote: > Hi, > > Thanks you very much for evaluating this so quickly :-) > > I was able to work around the issue by uninstalling pytest-drop-dup-tests. > Nevertheless I opens an issue there so this doesn't get lost. > > https://github.com/nicoddemus/pytest-drop-dup-tests/issues/3 > > -- > Regards > Hartmut Goebel > > | Hartmut Goebel | h.goebel at crazy-compilers.com | > | www.crazy-compilers.com | compilers which you thought are impossible | > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Fri Jan 17 06:09:55 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Fri, 17 Jan 2020 08:09:55 -0300 Subject: [pytest-dev] pytest 5.3.3 Message-ID: pytest 5.3.3 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The full changelog is available at https://docs.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Adam Johnson * Alexandre Mulatinho * Anthony Sottile * Bruno Oliveira * Chris NeJame * Daniel Hahler * Hugo van Kemenade * Marcelo Duarte Trevisani * PaulC * Ran Benita * Ryan Barner * Seth Junot * marc Happy testing, The pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Mon Jan 20 12:28:34 2020 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Mon, 20 Jan 2020 14:28:34 -0300 Subject: [pytest-dev] pytest 5.3.4 Message-ID: pytest 5.3.4 has just been released to PyPI. This is release reverts a regression introduced by a bug-fix in 5.3.3, all users affected should upgrade:: pip install --upgrade pytest The full changelog is available at https://docs.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Bruno Oliveira * Daniel Hahler * Ran Benita Happy testing, The pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From genml+pytest-dev at thequod.de Wed Jan 29 12:51:16 2020 From: genml+pytest-dev at thequod.de (Daniel Hahler) Date: Wed, 29 Jan 2020 18:51:16 +0100 Subject: [pytest-dev] pytest 5.3.5 Message-ID: <2a1f028f-1d12-09d9-07d0-7d8fbaf7f3c6@thequod.de> pytest 5.3.5 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The full changelog is available at https://docs.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Daniel Hahler * Ran Benita Happy testing, The pytest Development Team