[Python-3000-checkins] r51578 - python/branches/p3yk/Parser/asdl.py python/branches/p3yk/Parser/asdl_c.py

Brett Cannon brett at python.org
Fri Aug 25 02:16:08 CEST 2006


Possibly.  There are a few other places in the testing suite where there are
backticks.  I can change to use %r where appropriate when I check in those
removals as well.

-Brett

On 8/24/06, Neal Norwitz <nnorwitz at gmail.com> wrote:
>
> Would it be better to do '... %r ...' % value, instead of doing
> repr(value)?
>
> n
> --
>
> On 8/24/06, brett.cannon <python-3000-checkins at python.org> wrote:
> > Author: brett.cannon
> > Date: Fri Aug 25 01:44:42 2006
> > New Revision: 51578
> >
> > Modified:
> >    python/branches/p3yk/Parser/asdl.py
> >    python/branches/p3yk/Parser/asdl_c.py
> > Log:
> > Get rid of all two uses of backticks (bad Jeremy!).
> >
> >
> > Modified: python/branches/p3yk/Parser/asdl.py
> >
> ==============================================================================
> > --- python/branches/p3yk/Parser/asdl.py (original)
> > +++ python/branches/p3yk/Parser/asdl.py Fri Aug 25 01:44:42 2006
> > @@ -98,7 +98,7 @@
> >
> >      def t_default(self, s):
> >          r" . +"
> > -        raise ValueError, "unmatched input: %s" % `s`
> > +        raise ValueError, "unmatched input: %s" % repr(s)
> >
> >  class ASDLParser(spark.GenericParser, object):
> >      def __init__(self):
> >
> > Modified: python/branches/p3yk/Parser/asdl_c.py
> >
> ==============================================================================
> > --- python/branches/p3yk/Parser/asdl_c.py       (original)
> > +++ python/branches/p3yk/Parser/asdl_c.py       Fri Aug 25 01:44:42 2006
> > @@ -47,7 +47,7 @@
> >          # XXX this should be fixed for real
> >          if i == -1 and 'GeneratorExp' in cur:
> >              i = size + 3
> > -        assert i != -1, "Impossible line %d to reflow: %s" % (size,
> `s`)
> > +        assert i != -1, "Impossible line %d to reflow: %s" % (size,
> repr(s))
> >          lines.append(padding + cur[:i])
> >          if len(lines) == 1:
> >              # find new size based on brace
> > _______________________________________________
> > Python-3000-checkins mailing list
> > Python-3000-checkins at python.org
> > http://mail.python.org/mailman/listinfo/python-3000-checkins
> >
> _______________________________________________
> Python-3000-checkins mailing list
> Python-3000-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-3000-checkins
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.python.org/pipermail/python-3000-checkins/attachments/20060824/a527650b/attachment.html 


More information about the Python-3000-checkins mailing list