[Python-3000-checkins] r56934 - python/branches/py3k/Modules/gdbmmodule.c

martin.v.loewis python-3000-checkins at python.org
Sat Aug 11 21:28:54 CEST 2007


Author: martin.v.loewis
Date: Sat Aug 11 21:28:53 2007
New Revision: 56934

Modified:
   python/branches/py3k/Modules/gdbmmodule.c
Log:
Change module to produce and consume bytes.


Modified: python/branches/py3k/Modules/gdbmmodule.c
==============================================================================
--- python/branches/py3k/Modules/gdbmmodule.c	(original)
+++ python/branches/py3k/Modules/gdbmmodule.c	Sat Aug 11 21:28:53 2007
@@ -220,7 +220,7 @@
 
     key = gdbm_firstkey(dp->di_dbm);
     while (key.dptr) {
-        item = PyString_FromStringAndSize(key.dptr, key.dsize);
+        item = PyBytes_FromStringAndSize(key.dptr, key.dsize);
         if (item == NULL) {
             free(key.dptr);
             Py_DECREF(v);
@@ -251,19 +251,14 @@
 			"GDBM object has already been closed");
 	return -1;
     }
-    if (PyUnicode_Check(arg)) {
-        arg = _PyUnicode_AsDefaultEncodedString(arg, NULL);
-        if (arg == NULL)
-            return -1;
-    }
-    if (!PyString_Check(arg)) {
+    if (!PyBytes_Check(arg)) {
 	PyErr_Format(PyExc_TypeError,
-		     "gdbm key must be string, not %.100s",
+		     "gdbm key must be bytes, not %.100s",
 		     arg->ob_type->tp_name);
 	return -1;
     }
-    key.dptr = PyString_AS_STRING(arg);
-    key.dsize = PyString_GET_SIZE(arg);
+    key.dptr = PyBytes_AsString(arg);
+    key.dsize = PyBytes_Size(arg);
     return gdbm_exists(dp->di_dbm, key);
 }
 
@@ -296,7 +291,7 @@
     check_dbmobject_open(dp);
     key = gdbm_firstkey(dp->di_dbm);
     if (key.dptr) {
-        v = PyString_FromStringAndSize(key.dptr, key.dsize);
+        v = PyBytes_FromStringAndSize(key.dptr, key.dsize);
         free(key.dptr);
         return v;
     }
@@ -328,7 +323,7 @@
     check_dbmobject_open(dp);
     nextkey = gdbm_nextkey(dp->di_dbm, key);
     if (nextkey.dptr) {
-        v = PyString_FromStringAndSize(nextkey.dptr, nextkey.dsize);
+        v = PyBytes_FromStringAndSize(nextkey.dptr, nextkey.dsize);
         free(nextkey.dptr);
         return v;
     }
@@ -531,7 +526,7 @@
     DbmError = PyErr_NewException("gdbm.error", NULL, NULL);
     if (DbmError != NULL) {
         PyDict_SetItemString(d, "error", DbmError);
-        s = PyString_FromString(dbmmodule_open_flags);
+        s = PyUnicode_FromString(dbmmodule_open_flags);
         PyDict_SetItemString(d, "open_flags", s);
         Py_DECREF(s);
     }


More information about the Python-3000-checkins mailing list