[Python-3000-checkins] r56961 - python/branches/py3k/Objects/unicodeobject.c

neal.norwitz python-3000-checkins at python.org
Sun Aug 12 19:21:40 CEST 2007


Author: neal.norwitz
Date: Sun Aug 12 19:21:38 2007
New Revision: 56961

Modified:
   python/branches/py3k/Objects/unicodeobject.c
Log:
Add comment that should be addressed

Modified: python/branches/py3k/Objects/unicodeobject.c
==============================================================================
--- python/branches/py3k/Objects/unicodeobject.c	(original)
+++ python/branches/py3k/Objects/unicodeobject.c	Sun Aug 12 19:21:38 2007
@@ -1188,6 +1188,9 @@
         return v;
     if (errors != NULL)
         Py_FatalError("non-NULL encoding in _PyUnicode_AsDefaultEncodedString");
+    /* XXX(nnorwitz): errors will always be NULL due to the check above.
+	Should this check and the else be removed since it's dead code?
+     */
     if (errors == NULL) {
         b = PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode),
                                  PyUnicode_GET_SIZE(unicode),


More information about the Python-3000-checkins mailing list