[Python-3000-checkins] r54433 - in python/branches/p3yk: Doc/api/concrete.tex Doc/api/refcounts.dat Include/floatobject.h Misc/NEWS Objects/abstract.c Objects/floatobject.c
georg.brandl
python-3000-checkins at python.org
Sun Mar 18 19:35:20 CET 2007
Author: georg.brandl
Date: Sun Mar 18 19:35:15 2007
New Revision: 54433
Modified:
python/branches/p3yk/Doc/api/concrete.tex
python/branches/p3yk/Doc/api/refcounts.dat
python/branches/p3yk/Include/floatobject.h
python/branches/p3yk/Misc/NEWS
python/branches/p3yk/Objects/abstract.c
python/branches/p3yk/Objects/floatobject.c
Log:
Remove the deprecated and useless "pend" argument from
PyFloat_FromString. (fixes bug #1650903)
Modified: python/branches/p3yk/Doc/api/concrete.tex
==============================================================================
--- python/branches/p3yk/Doc/api/concrete.tex (original)
+++ python/branches/p3yk/Doc/api/concrete.tex Sun Mar 18 19:35:15 2007
@@ -430,10 +430,9 @@
\versionadded{2.2}
\end{cfuncdesc}
-\begin{cfuncdesc}{PyObject*}{PyFloat_FromString}{PyObject *str, char **pend}
+\begin{cfuncdesc}{PyObject*}{PyFloat_FromString}{PyObject *str}
Create a \ctype{PyFloatObject} object based on the string value in
- \var{str}, or \NULL{} on failure. The \var{pend} argument is ignored. It
- remains only for backward compatibility.
+ \var{str}, or \NULL{} on failure.
\end{cfuncdesc}
\begin{cfuncdesc}{PyObject*}{PyFloat_FromDouble}{double v}
Modified: python/branches/p3yk/Doc/api/refcounts.dat
==============================================================================
--- python/branches/p3yk/Doc/api/refcounts.dat (original)
+++ python/branches/p3yk/Doc/api/refcounts.dat Sun Mar 18 19:35:15 2007
@@ -385,7 +385,6 @@
PyFloat_FromString:PyObject*::+1:
PyFloat_FromString:PyObject*:str:0:
-PyFloat_FromString:char**:pend:0:ignored
PyFrozenSet_New:PyObject*::+1:
PyFrozenSet_New:PyObject*:iterable:0:
Modified: python/branches/p3yk/Include/floatobject.h
==============================================================================
--- python/branches/p3yk/Include/floatobject.h (original)
+++ python/branches/p3yk/Include/floatobject.h Sun Mar 18 19:35:15 2007
@@ -21,10 +21,8 @@
#define PyFloat_Check(op) PyObject_TypeCheck(op, &PyFloat_Type)
#define PyFloat_CheckExact(op) ((op)->ob_type == &PyFloat_Type)
-/* Return Python float from string PyObject. Second argument ignored on
- input, and, if non-NULL, NULL is stored into *junk (this tried to serve a
- purpose once but can't be made to work as intended). */
-PyAPI_FUNC(PyObject *) PyFloat_FromString(PyObject*, char** junk);
+/* Return Python float from string PyObject. */
+PyAPI_FUNC(PyObject *) PyFloat_FromString(PyObject*);
/* Return Python float from C double. */
PyAPI_FUNC(PyObject *) PyFloat_FromDouble(double);
Modified: python/branches/p3yk/Misc/NEWS
==============================================================================
--- python/branches/p3yk/Misc/NEWS (original)
+++ python/branches/p3yk/Misc/NEWS Sun Mar 18 19:35:15 2007
@@ -28,6 +28,9 @@
Core and Builtins
-----------------
+- The long-deprecated argument "pend" of PyFloat_FromString() has been
+ removed.
+
- The dir() function has been extended to call the __dir__() method on
its argument, if it exists. If not, it will work like before. This allows
customizing the output of dir() in the presence of a __getattr__().
Modified: python/branches/p3yk/Objects/abstract.c
==============================================================================
--- python/branches/p3yk/Objects/abstract.c (original)
+++ python/branches/p3yk/Objects/abstract.c Sun Mar 18 19:35:15 2007
@@ -968,7 +968,7 @@
PyFloatObject *po = (PyFloatObject *)o;
return PyFloat_FromDouble(po->ob_fval);
}
- return PyFloat_FromString(o, NULL);
+ return PyFloat_FromString(o);
}
/* Operations on sequences */
Modified: python/branches/p3yk/Objects/floatobject.c
==============================================================================
--- python/branches/p3yk/Objects/floatobject.c (original)
+++ python/branches/p3yk/Objects/floatobject.c Sun Mar 18 19:35:15 2007
@@ -62,24 +62,8 @@
return (PyObject *) op;
}
-/**************************************************************************
-RED_FLAG 22-Sep-2000 tim
-PyFloat_FromString's pend argument is braindead. Prior to this RED_FLAG,
-
-1. If v was a regular string, *pend was set to point to its terminating
- null byte. That's useless (the caller can find that without any
- help from this function!).
-
-2. If v was a Unicode string, or an object convertible to a character
- buffer, *pend was set to point into stack trash (the auto temp
- vector holding the character buffer). That was downright dangerous.
-
-Since we can't change the interface of a public API function, pend is
-still supported but now *officially* useless: if pend is not NULL,
-*pend is set to NULL.
-**************************************************************************/
PyObject *
-PyFloat_FromString(PyObject *v, char **pend)
+PyFloat_FromString(PyObject *v)
{
const char *s, *last, *end;
double x;
@@ -89,8 +73,6 @@
#endif
Py_ssize_t len;
- if (pend)
- *pend = NULL;
if (PyString_Check(v)) {
s = PyString_AS_STRING(v);
len = PyString_GET_SIZE(v);
@@ -852,7 +834,7 @@
if (!PyArg_ParseTupleAndKeywords(args, kwds, "|O:float", kwlist, &x))
return NULL;
if (PyString_Check(x))
- return PyFloat_FromString(x, NULL);
+ return PyFloat_FromString(x);
return PyNumber_Float(x);
}
More information about the Python-3000-checkins
mailing list