[Python-3000-checkins] r55220 - python/branches/py3k-struni/Lib/test/test_codecs.py

Walter Dörwald walter at livinglogic.de
Fri May 11 13:26:14 CEST 2007


Guido van Rossum wrote:
> On 5/10/07, Walter Dörwald <walter at livinglogic.de> wrote:
>> Guido van Rossum wrote:
>>
>> > Yeah, the solution is to use io.BytesIO where bytes are read/written.
>>
>> Done, most remaining errors are from the CJK codecs and from the idna 
>> codec.

OK, the idna codecs is fixed now too.

BTW, the message from the pre-commit hook is somewhat unhelpful:

svn: 'pre-commit' hook failed with error output:
file /python/branches/py3k-struni/Lib/encodings/idna.py is not 
whitespace-normalized

If possible the message should include info about the nature of the 
problem (tabs, trailing whitespace) and it's location.

>> BTW, would it make sense to use io.StringIO instead of StringIO.StringIO
>>   for the remaining uses in test_codecs.py?
> 
> Not yes -- io.StringIO is currently quite broken.
> 
>> Is the StringIO module supposed to die?
> 
> Yes. If you feel like fixing io.StringIO that would be great! It
> probably was a mistake to attempt to share code with BytesIO.

Why not simply copy over StrignIO.StringIO?

Servus,
    Walter




More information about the Python-3000-checkins mailing list