[Python-3000-checkins] r67539 - in python/branches/py3k: Lib/webbrowser.py Misc/NEWS

amaury.forgeotdarc python-3000-checkins at python.org
Fri Dec 5 02:02:22 CET 2008


Author: amaury.forgeotdarc
Date: Fri Dec  5 02:02:21 2008
New Revision: 67539

Log:
Issue #4537: webbrowser.UnixBrowser failed because this module defines an open()
function which shadows the builtin.

Will backport to 3.0


Modified:
   python/branches/py3k/Lib/webbrowser.py
   python/branches/py3k/Misc/NEWS

Modified: python/branches/py3k/Lib/webbrowser.py
==============================================================================
--- python/branches/py3k/Lib/webbrowser.py	(original)
+++ python/branches/py3k/Lib/webbrowser.py	Fri Dec  5 02:02:21 2008
@@ -223,7 +223,7 @@
         cmdline = [self.name] + raise_opt + args
 
         if remote or self.background:
-            inout = open(os.devnull, "r+")
+            inout = io.open(os.devnull, "r+")
         else:
             # for TTY browsers, we need stdin/out
             inout = None

Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Fri Dec  5 02:02:21 2008
@@ -16,6 +16,9 @@
 Library
 -------
 
+- Issue #4537: webbrowser.UnixBrowser would fail to open the browser because
+  it was calling the wrong open() function.
+
 - Issue #1055234: cgi.parse_header(): Fixed parsing of header parameters to
   support unusual filenames (such as those containing semi-colons) in
   Content-Disposition headers.


More information about the Python-3000-checkins mailing list