[Python-3000-checkins] r61717 - python/branches/py3k/Python/getargs.c

[georg.brandl]

Author: georg.brandl
Date: Fri Mar 21 21:46:11 2008
New Revision: 61717

Modified:
   python/branches/py3k/Python/getargs.c
Log:
Add XXX comments for whoever cleans up getargs.c :)


Modified: python/branches/py3k/Python/getargs.c
==============================================================================
--- python/branches/py3k/Python/getargs.c	(original)
+++ python/branches/py3k/Python/getargs.c	Fri Mar 21 21:46:11 2008
@@ -823,6 +823,9 @@
 			}
 			else
 				return converterr("string", arg, msgbuf, bufsize);
+			/* XXX(gb): this test is completely wrong -- p is a
+			 * byte string while arg is a Unicode. I *think* it should
+			 * check against the size of uarg... */
 			if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr("string without null bytes",
 						  arg, msgbuf, bufsize);
@@ -898,6 +901,7 @@
 				}
 				format++;
 			}
+			/* XXX(gb): same comment as for 's' applies here... */
 			else if (*p != NULL &&
 				 (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr(